refactor(ses): Update inert constructor error messages and add tests #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
force-pushed
the
inert-constructor-tests
branch
from
d9d0c48
to
5195be2
Compare
rekmarks
force-pushed
the
inert-constructor-tests
branch
from
5195be2
to
cc171c1
Compare
mhofman
reviewed
Sep 20, 2021
| @@ -75,7 +75,9 @@ export default function tameFunctionConstructors() { | |||
| // prototype of functions. | |||
| // eslint-disable-next-line func-names | |||
| const InertConstructor = function() { | |||
| throw new TypeError('Not available'); | |||
| throw new TypeError( | |||
| 'Function.prototype.constructor is not a valid constructor.', | |||
There was a problem hiding this comment.
Suggested change
| 'Function.prototype.constructor is not a valid constructor.', | |
| `${name}.prototype.constructor is not a valid constructor.`, |
kriskowal
pushed a commit
that referenced
this pull request
Jan 20, 2022
* fix: tolerate endo pre and post #822
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the error messages of errors thrown by inert function constructors and add tests to ensure that they do in fact throw those errors after lockdown.