test(cli): Fix failing cli tests #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
force-pushed
the
sirtimid/fix-cli-tests
branch
from
cd6273a
to
77a67f4
Compare
rekmarks
requested changes
Sep 18, 2024
sirtimid
force-pushed
the
sirtimid/fix-cli-tests
branch
from
77a67f4
to
1121112
Compare
sirtimid
changed the title
kriskowal
approved these changes
Sep 19, 2024
|
@sirtimid Please rebase on |
|
@sirtimid Since you only have one significant commit, “squash merge” is also fine. The default commit message for the merge commit is your description above, which is also fine as writ. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2409
Refs: #2384
Description
This PR updates the readme to properly document the
listcli command and fixes the failing testsSecurity Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
none
Compatibility Considerations
none
Upgrade Considerations
none