Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileResponse not listening for http.disconnect #1302

Closed

Commits on Oct 9, 2021

  1. Fix FileResponse not listening for http.disconnect

     - implement aborting FileResponse stream on http.disconnect similar to
       StreamResponse
     - implement on_complete Background Tasks for
       StreamResponse/FileResponse
        - background: always executed (even if stream aborted)
        - on_complete: only executed if stream not abored by client
       I initially assumed that background would work as on_complete is now
       implemented. However as this is not the case, adding on_complete
       seemed like the best choice to ensure backwards compatibility.
     - implement testsuite for abort scenarios
    idotobi committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    ff5e3c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. Fix broken test cases (and warnings)

    Warnings:
     - change invalid permissions after test as otherwise pytest cannot
       clean the tmpdir
    
    Errors:
     - get free tcp/udp port dynamically for test_response_abort
     - use global variable for defining sleep values
    idotobi committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    8ab0861 View commit details
    Browse the repository at this point in the history