Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing py.typed file #361

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Fix missing py.typed file #361

merged 1 commit into from
Sep 19, 2019

Conversation

florimondmanca
Copy link
Member

Fixes #193

I realized zip_safe=False was missing by comparing with Starlette. Upon more research, it seems this is actually a mypy/setuptools requirement.

My QA process:

python -m venv venv
. venv/bin/activate
pip install /path/to/httpx
ls venv/lib/python3.7/site-packages/httpx | grep py.typed
# OK

@florimondmanca
Add zip_safe=False to setup()
33fe98a 
This fixes `py.typed` not being included in the built package
sethmlarson
sethmlarson approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️ Thanks @florimondmanca!

@sethmlarson sethmlarson merged commit 061d943 into master Sep 19, 2019
@sethmlarson sethmlarson deleted the fix-include-py-typed branch September 19, 2019 16:13
@jhonatan-lopes jhonatan-lopes mentioned this pull request Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing py.typed declaration?
2 participants
@florimondmanca @sethmlarson