-
-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate app=...
in favor of explicit WSGITransport
/ASGITransport
.
#3050
Merged
Merged
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
80fbfce
Deprecate app=... in favour of explicit WSGITransport/ASGITransport
tomchristie 63143fb
Linting
tomchristie 647b250
Linting
tomchristie 7e14912
Merge branch 'master' into deprecate-app
tomchristie 9f786f2
Update WSGITransport and ASGITransport docs
tomchristie 041470b
Merge branch 'master' into deprecate-app
tomchristie 943ab73
Merge master
tomchristie aab0b00
Merge branch 'master' into deprecate-app
tomchristie fb2e30e
Deprecate app
tomchristie 34ff320
Drop deprecation tests
tomchristie 7e34a37
Add CHANGELOG
tomchristie 21b36a5
Merge branch 'master' into deprecate-app
tomchristie 4ab79fb
Deprecate 'app=...' shortcut, rather than removing it.
tomchristie 468bdfc
Update CHANGELOG
tomchristie abf9dee
Fix test_asgi.test_deprecated_shortcut
tomchristie ab27c99
Merge branch 'master' into deprecate-app
tomchristie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this PR is version 1.0 proposal, why don't you track its changelog in #3069 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/encode/httpx/pull/3069/files#diff-75bb3ae57865eb28e99c3e4fff3efc72a5d49e3f14ac324195b405058cb9731aR13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then do we need to re-mention it in this PR?
All other open PRs with
1.0 proposal
tag don't include changelog independently.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should do before approval.
(We should include CHANGELOG entries with the PRs as usual.)