Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop private import of 'encode_request' in test_multipart #2525

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Dec 31, 2022

Refs #2492

This is just a test refactoring.

Use httpx.Request(...) to handle the multipart tests, rather than importing the encode_request function, which is a private implementation detail. Having tests against our public API makes more sense than digging into private imports.

@tomchristie tomchristie added the refactor Issues and PRs related to code refactoring label Jan 4, 2023
@tomchristie tomchristie requested a review from a team January 10, 2023 11:18
Copy link
Member

@michaeloliverx michaeloliverx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to dog food the public API.

@tomchristie tomchristie merged commit 7947b56 into master Jan 10, 2023
@tomchristie tomchristie deleted the drop-private-import-in-test-multipart branch January 10, 2023 11:23
@tomchristie tomchristie mentioned this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues and PRs related to code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants