-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust max streams when remote settings change #652
Conversation
Not sure where to put this so I'll just add it as another message. When I tested this against APNS, I was able to see the settings change come in. This is what the change in max concurrent streams specifically looked like:
|
0e6b798
to
a2450a1
Compare
If the remote server sends a settings update for `max_concurrent_streams`, check and potentially update the max number of streams we will use for a connection.
a2450a1
to
8d70914
Compare
Hello @tomchristie, just wanted to reach out to see if you or somebody from the encode team could review this? Thanks! |
Great stuff, thanks! 🎉 The CI reports a linting failure indicating that the async and sync versions don't match. You can resolve this locally by running I'd suggest resolving that first. Then you might want to take a look at https://github.com/encode/httpcore/blob/master/tests/_async/test_http2.py and see if you're able to add some test coverage for this. |
f7aefc6
to
4e3e596
Compare
Improve testing for remote max streams update This new test checks whether a change in the max streams setting is properly handled. The max streams value is changed twice throughout the mock stream. The first update increases the value while the second update decreases it.
4e3e596
to
bf604e0
Compare
Okay I think this is good to go! Let me know if there are any other changes you would like me to make. |
Hey @tomchristie! Just checking in to see what you think of the recent commits with the added tests? |
Great work, thanks! |
Would be interesting to see this working together with our latest logging update... |
Thanks for the merge!
Are you planning on bumping the |
If the remote server sends a settings update for
max_concurrent_streams
, check and potentially update the max number of streams we will use for a connection.This is related to encode/httpx#2416.