Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message cache handling #32

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Improve message cache handling #32

merged 3 commits into from
Sep 7, 2024

Conversation

DerAndereAndi
Copy link
Member

  • Refactor read message caching
    • Move to Sender, to be remote device specific
    • Use for all request messages (read, subscribe, unsubscribe, bind, unbind)
  • WriteApproval handling updates
    • Clean up approval msg cache on device disconnects
    • Make them remote device specific
  • ReponseMsgCallbacks updates
    • Support multiple callbacks for a single msgCounter (required due to request caching)
  • datagram addition fixes

- Refactor read message caching
  - Move to Sender, to be remote device specific
  - Use for all request messages (read, subscribe, unsubscribe, bind, unbind)
- WriteApproval handling updates
  - Clean up approval msg cache on device disconnects
  - Make them remote device specific
- ReponseMsgCallbacks updates
  - Support multiple callbacks for a single msgCounter (required due to request caching)
- datagram addition fixes
@coveralls
Copy link

coveralls commented Sep 7, 2024

Coverage Status

coverage: 93.615% (+0.06%) from 93.556%
when pulling ee706e3 on feature/cache-fix
into dd82619 on dev.

@DerAndereAndi DerAndereAndi merged commit 4e14507 into dev Sep 7, 2024
6 checks passed
@DerAndereAndi DerAndereAndi deleted the feature/cache-fix branch September 7, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants