Remove use of legacy proxy API from library_html5.js. NFC #20370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_use_of_legacy_proxy_api
branch
from
99bae4f
to
1cb518d
Compare
tlively
approved these changes
Oct 2, 2023
system/lib/html5/callback.c
Outdated
| static void do_callback(void* arg) { | ||
| callback_args_t* args = (callback_args_t*)arg; | ||
| args->callback(args->event_type, args->event_data, args->user_data); | ||
| free(arg); |
There was a problem hiding this comment.
No need to free since arg is stack allocated.
AFAICT this is the final usage of the legacy proxy API within emscripten.
sbc100
force-pushed
the
remove_use_of_legacy_proxy_api
branch
from
1cb518d
to
e58cb95
Compare
stbergmann
added a commit
to stbergmann/emscripten
that referenced
this pull request
Aug 23, 2024
...fixing a regression introduced in c41f659 "Remove use of legacy proxy API from library_html5.js. NFC (emscripten-core#20370)". Fixes: emscripten-core#22442
stbergmann
added a commit
to stbergmann/emscripten
that referenced
this pull request
Sep 3, 2024
...fixing a regression introduced in c41f659 "Remove use of legacy proxy API from library_html5.js. NFC (emscripten-core#20370)". Fixes: emscripten-core#22442
stbergmann
added a commit
to stbergmann/emscripten
that referenced
this pull request
Sep 16, 2024
...fixing a regression introduced in c41f659 "Remove use of legacy proxy API from library_html5.js. NFC (emscripten-core#20370)". Fixes: emscripten-core#22442
stbergmann
added a commit
to allotropia/emscripten
that referenced
this pull request
Sep 18, 2024
...fixing a regression introduced in c41f659 "Remove use of legacy proxy API from library_html5.js. NFC (emscripten-core#20370)". Fixes: emscripten-core#22442 (cherry-picked from 17f1bb7 at <emscripten-core#22443> "Make _emscripten_run_callback_on_thread asynchronous")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICT this is the final usage of the legacy proxy API within emscripten.