Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new recv_callback to mqtt_client obj #198

Merged
merged 7 commits into from
Jul 21, 2023
Merged

Add new recv_callback to mqtt_client obj #198

merged 7 commits into from
Jul 21, 2023

Conversation

JaylinYu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (b42fb5f) 59.02% compared to head (e8db762) 58.99%.

❗ Current head e8db762 differs from pull request most recent head 0a620b8. Consider uploading reports for the commit 0a620b8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   59.02%   58.99%   -0.03%     
==========================================
  Files          96       96              
  Lines       26537    26555      +18     
==========================================
+ Hits        15663    15667       +4     
- Misses      10874    10888      +14     
Impacted Files Coverage Δ
src/supplemental/mqtt/mqtt_public.c 14.83% <0.00%> (-0.78%) ⬇️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JaylinYu JaylinYu requested review from wanghaEMQ, xinyi-xs, RanMaoyi and eeff and removed request for wanghaEMQ July 20, 2023 11:43
Copy link
Member

@RanMaoyi RanMaoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaylinYu JaylinYu merged commit 6748368 into main Jul 21, 2023
11 of 14 checks passed
@JaylinYu JaylinYu deleted the jaylin/sdk branch July 21, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants