Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* FIX [mqttv5_quic] fix explicit closing socket under qos_first condi… #194

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

JaylinYu
Copy link
Member

No description provided.

@JaylinYu JaylinYu requested a review from wanghaEMQ July 12, 2023 06:18
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (25122ae) 58.85% compared to head (7c03359) 58.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   58.85%   58.83%   -0.03%     
==========================================
  Files          96       96              
  Lines       26536    26536              
==========================================
- Hits        15619    15613       -6     
- Misses      10917    10923       +6     
Impacted Files Coverage Δ
src/mqtt/protocol/mqtt/mqtt_quic.c 0.00% <0.00%> (ø)
src/mqtt/protocol/mqtt/mqttv5_quic.c 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

wanghaEMQ
wanghaEMQ previously approved these changes Jul 12, 2023
xinyi-xs
xinyi-xs previously approved these changes Jul 13, 2023
@JaylinYu JaylinYu dismissed stale reviews from xinyi-xs and wanghaEMQ via 7c03359 July 14, 2023 08:25
Copy link
Member Author

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz approve @wanghaEMQ

@JaylinYu JaylinYu merged commit 1efe3b3 into main Jul 14, 2023
10 of 16 checks passed
@JaylinYu JaylinYu deleted the jaylin/sdk branch July 14, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants