Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrong length in decoding publish packet. #154

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

wanghaEMQ
Copy link
Member

No description provided.

Copy link
Contributor

@alvin1221 alvin1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.22 🎉

Comparison is base (3248d1c) 61.42% compared to head (7def966) 61.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   61.42%   61.65%   +0.22%     
==========================================
  Files          99       99              
  Lines       26480    26483       +3     
==========================================
+ Hits        16266    16328      +62     
+ Misses      10214    10155      -59     
Impacted Files Coverage Δ
src/supplemental/mqtt/mqtt_codec.c 42.42% <100.00%> (+0.02%) ⬆️

... and 17 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alvin thank wangha

@JaylinYu JaylinYu merged commit 0a0d8e7 into main Mar 31, 2023
@JaylinYu JaylinYu deleted the wangha/fix branch March 31, 2023 04:30
Copy link
Contributor

@xinyi-xs xinyi-xs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants