Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some errors in SYNC before #143

Merged
merged 4 commits into from
Mar 21, 2023
Merged

Fix some errors in SYNC before #143

merged 4 commits into from
Mar 21, 2023

Conversation

wanghaEMQ
Copy link
Member

  • OpenSSL dependence problem.
  • Configuration not works.
  • Setting wrong QUIC option values.
  • Add some comment on QUIC options.

@wanghaEMQ wanghaEMQ requested review from xinyi-xs, alvin1221 and JaylinYu and removed request for xinyi-xs March 20, 2023 11:31
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.13 ⚠️

Comparison is base (b57eac8) 54.58% compared to head (96d3b65) 54.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   54.58%   54.46%   -0.13%     
==========================================
  Files          95       95              
  Lines       25333    25333              
==========================================
- Hits        13828    13797      -31     
- Misses      11505    11536      +31     
Impacted Files Coverage Δ
src/mqtt/protocol/mqtt/mqtt_quic.c 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JaylinYu JaylinYu merged commit e6f5a44 into main Mar 21, 2023
@JaylinYu JaylinYu deleted the wangha/sync branch March 21, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants