Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: SHA256 support #1032

Merged
merged 4 commits into from
Mar 23, 2024
Merged

Feature: SHA256 support #1032

merged 4 commits into from
Mar 23, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Mar 22, 2024

No description provided.

@emmercm emmercm self-assigned this Mar 22, 2024
Copy link

github-actions bot commented Mar 22, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/sha256" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 87.65432% with 10 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@4aebb8d). Click here to learn what that means.

Files Patch % Lines
src/modules/candidateWriter.ts 25.00% 6 Missing ⚠️
src/types/dats/dat.ts 0.00% 1 Missing and 1 partial ⚠️
src/types/indexedFiles.ts 87.50% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1032   +/-   ##
=======================================
  Coverage        ?   93.20%           
=======================================
  Files           ?       92           
  Lines           ?     5963           
  Branches        ?     1429           
=======================================
  Hits            ?     5558           
  Misses          ?      384           
  Partials        ?       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 49d1e7e into main Mar 23, 2024
52 of 53 checks passed
@emmercm emmercm deleted the emmercm/sha256 branch March 23, 2024 15:58
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant