Add hifitime datepicker & make datepicker generic #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Massou31
force-pushed
the
master
branch
4 times, most recently
from
73aa5b2
to
6348a21
Compare
|
I've just changed the implementation in order to make an abstraction on the datepicker, this way any date/time library could be used as long as the required trait is implemented. There is 1 known bug regarding how I compute the week number with hifitime (I plan to fix it sometime in the next 2 weeks, I'll remove the draft status once it's fixed) @emilk I think that this pull request could have an initial review. EDIT: the last commit computes the iso week correctly |
Massou31
force-pushed
the
master
branch
2 times, most recently
from
933b57c
to
2bb7e09
Compare
Massou31
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've copy/pasted my changes to the datepicker that uses https://github.com/nyx-space/hifitime
I've tested succinctly and it works but there may be some edge cases not handled yet.
scripts/check.sh do not work yet because the features are not mutually exclusive (after a quick check I found this: rust-lang/cargo#2980 but it seem that some mitigations are possible).
I'll dig further on the features later this week or next week as well as more testing.
Closes #2932.