Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added snapScheduleParameters in the modify method #345

Merged
merged 6 commits into from
May 14, 2021
Merged

Added snapScheduleParameters in the modify method #345

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c1128f
Added snapScheduleParameters in the modify method so that snap schedu…
May 10, 2021
d1c2ebf
Added snapScheduleParameters in the modify method so that snap schedu…
May 11, 2021
ffe6354
Add the unit test and also added the data in index.json
May 13, 2021
f7e52d4
flake8 issue resolution
May 13, 2021
386c1b1
Addressed flake8 issues
May 13, 2021
f21b932
Changed the parameter name from snapScheduleParameters to snap_schedu…
May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion storops/unity/resource/filesystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def create(cls, cli, pool, nas_server, name, size, proto=None,
def modify(self, size=None, is_thin=None, tiering_policy=None,
user_cap=False, is_compression=None, access_policy=None,
locking_policy=None, description=None,
cifs_fs_parameters=None):
cifs_fs_parameters=None, snapScheduleParameters=None):
meenakshidembi691 marked this conversation as resolved.
Show resolved Hide resolved
sr = self.storage_resource
if sr is None:
raise ValueError('storage resource for filesystem {} not found.'
Expand All @@ -103,6 +103,8 @@ def modify(self, size=None, is_thin=None, tiering_policy=None,
params['cifsFsParameters'] = cifs_fs_parameters
if description is not None:
params['description'] = description
if snapScheduleParameters:
meenakshidembi691 marked this conversation as resolved.
Show resolved Hide resolved
meenakshidembi691 marked this conversation as resolved.
Show resolved Hide resolved
params['snapScheduleParameters'] = snapScheduleParameters
meenakshidembi691 marked this conversation as resolved.
Show resolved Hide resolved

if not params:
return RestResponse('', self._cli)
Expand Down
7 changes: 7 additions & 0 deletions storops_test/unity/resource/test_filesystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,13 @@ def test_modify_success_empty_description(self):
fs.modify(description='')
assert_that(fs.description, equal_to(''))

@patch_rest
def test_modify_success_snap_schedule(self):
fs = UnityFileSystem(cli=t_rest(), _id='fs_22')
snapScheduleParameters = {'snapSchedule': {'id': 'snapSch_1'}}
meenakshidembi691 marked this conversation as resolved.
Show resolved Hide resolved
resp = fs.modify(snapScheduleParameters=snapScheduleParameters)
meenakshidembi691 marked this conversation as resolved.
Show resolved Hide resolved
assert_that(resp.is_ok(), equal_to(True))

@patch_rest
def test_delete_filesystem_async(self):
fs = UnityFileSystem(_id='fs_14', cli=t_rest())
Expand Down
11 changes: 11 additions & 0 deletions storops_test/unity/rest_data/storageResource/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,17 @@
},
"response": "size_too_small.json"
},
{
"url": "/api/instances/storageResource/res_22/action/modifyFilesystem?compact=True",
"body": {
"snapScheduleParameters": {
"snapSchedule": {
"id": "snapSch_1"
}
}
},
"response": "empty.json"
},
{
"url": "/api/types/storageResource/action/createFilesystem?compact=True",
"body": {
Expand Down