Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more parameters for file create, modify interfaces #331

Merged
merged 4 commits into from
Nov 3, 2020

Conversation

yong-huang
Copy link
Contributor

Add more parameters for the filesystem, nfs share, cifs share creation, modification interfaces.

Major changes:

  • UnityFileSystem create, modify, create_nfs_share, create_cifs_share methods
  • UnityNfsShare create, create_from_snap, modify methods
  • UnityCifsShare create, create_from_snap, modify methods
  • UnityPool create_filesystem,create_nfs_share methods
  • UnityJob create_nfs_share method

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #331 into master will increase coverage by 0.02%.
The diff coverage is 95.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   91.67%   91.70%   +0.02%     
==========================================
  Files          99       99              
  Lines       13769    13927     +158     
  Branches     1663     1686      +23     
==========================================
+ Hits        12623    12772     +149     
- Misses        733      741       +8     
- Partials      413      414       +1     
Impacted Files Coverage Δ
storops/unity/resource/nfs_share.py 84.14% <88.00%> (-0.07%) ⬇️
storops/unity/resource/filesystem.py 92.90% <94.91%> (+0.27%) ⬆️
storops/exception.py 97.40% <100.00%> (+0.12%) ⬆️
storops/unity/enums.py 98.83% <100.00%> (+<0.01%) ⬆️
storops/unity/resource/cifs_share.py 88.20% <100.00%> (+1.75%) ⬆️
storops/unity/resource/job.py 95.57% <100.00%> (+0.38%) ⬆️
storops/unity/resource/pool.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8ef8f...86da09f. Read the comment docs.

@yong-huang yong-huang merged commit 0437478 into master Nov 3, 2020
@yong-huang yong-huang deleted the fs-nfs-cifs-modification branch November 3, 2020 09:51
yong-huang added a commit that referenced this pull request Nov 24, 2020
- bd19185 [#323] Unity: add advanced dedup support (#324)
- e435790 Unity: fix fs/nfs/cifs issues (#335)
- d4a2818 VNX: support to specify SP in LUN creation (#334)
- 0437478 [#325] Unity: add parameters for fs/nfs/cifs create and modify (#331)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants