Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme #58

Merged
merged 18 commits into from
Jul 2, 2024
Merged

Update readme #58

merged 18 commits into from
Jul 2, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Feb 18, 2024 •
edited
Loading

Closes: #53

Rendered: https://github.com/embroider-build/release-plan/blob/update-readme/README.md

Goal: prepare release-plan for more broad usage from outside our pocked of the JS community

@NullVoxPopuli NullVoxPopuli mentioned this pull request Feb 18, 2024
Closed
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review February 18, 2024 22:29
evoactivity
evoactivity reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@evoactivity evoactivity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Some emojis for feature list
  • fixed typos I spotted

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
evoactivity
evoactivity reviewed Feb 19, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
evoactivity
evoactivity reviewed Feb 19, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
NullVoxPopuli and others added 2 commits February 18, 2024 19:36
@NullVoxPopuli @evoactivity
Update README.md
38f89ec 
Co-authored-by: Liam Potter <radioactivity@gmail.com>
@NullVoxPopuli @evoactivity
Update README.md
d50caeb 
Co-authored-by: Liam Potter <radioactivity@gmail.com>
evoactivity
evoactivity reviewed Feb 19, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
NullVoxPopuli and others added 11 commits February 18, 2024 19:37
@NullVoxPopuli @evoactivity
Update README.md
f4c96f1 
Co-authored-by: Liam Potter <radioactivity@gmail.com>
@NullVoxPopuli @evoactivity
Update README.md
044a68e 
Co-authored-by: Liam Potter <radioactivity@gmail.com>
@NullVoxPopuli @evoactivity
Update README.md
c776606 
Co-authored-by: Liam Potter <radioactivity@gmail.com>
@NullVoxPopuli @evoactivity
Update README.md
b613495 
Co-authored-by: Liam Potter <radioactivity@gmail.com>
@NullVoxPopuli @evoactivity
Update README.md
412fbc8 
Co-authored-by: Liam Potter <radioactivity@gmail.com>
@NullVoxPopuli @evoactivity
Update README.md
3f2448a 
Co-authored-by: Liam Potter <radioactivity@gmail.com>
@NullVoxPopuli @evoactivity
Update README.md
c84624d 
Co-authored-by: Liam Potter <radioactivity@gmail.com>
@NullVoxPopuli @evoactivity
Update README.md
8a17895 
Co-authored-by: Liam Potter <radioactivity@gmail.com>
@NullVoxPopuli
Add a tagline and move the embroider origin to the bottom of the README
5a4f881
@NullVoxPopuli
Tweak statement
02f5764
@NullVoxPopuli
Update
041cb49
IgnaceMaes
IgnaceMaes approved these changes Apr 18, 2024
View reviewed changes
Copy link

@IgnaceMaes IgnaceMaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a lot of experience with this tool, but this README already helps me a bunch in understanding it compared to the current one.

So even if it might not be considered perfect I think it's already a great improvement.

mansona
mansona approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things that I would change but let's fix forward

@mansona mansona merged commit 9a92e6f into main Jul 2, 2024
2 checks passed
@mansona mansona deleted the update-readme branch July 2, 2024 13:06
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Merged
@mansona mansona added the documentation Improvements or additions to documentation label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evoactivity evoactivity evoactivity left review comments

@mansona mansona mansona approved these changes

@IgnaceMaes IgnaceMaes IgnaceMaes approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comparison
4 participants
@NullVoxPopuli @evoactivity @mansona @IgnaceMaes