Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on importing a module for side affects only to the README.md #594

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

keithZmudzinski
Copy link
Contributor

Add section on importing a module for side affects only

Fixes #593

Add section on importing a module for side affects only
@keithZmudzinski
Copy link
Contributor Author

@ef4 Here's the PR related to the issue that you helped me with! Thanks for walking me through on how to get it started

Copy link
Contributor

@lolmaus lolmaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Added a few minor fixes.

packages/ember-auto-import/README.md Outdated Show resolved Hide resolved
packages/ember-auto-import/README.md Show resolved Hide resolved
packages/ember-auto-import/README.md Outdated Show resolved Hide resolved
packages/ember-auto-import/README.md Outdated Show resolved Hide resolved
mansona and others added 4 commits November 1, 2023 16:27
Co-authored-by: Andrey Mikhaylov (lolmaus) <lolmaus@gmail.com>
Co-authored-by: Andrey Mikhaylov (lolmaus) <lolmaus@gmail.com>
Co-authored-by: Andrey Mikhaylov (lolmaus) <lolmaus@gmail.com>
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mansona mansona merged commit 22fa232 into embroider-build:main Nov 1, 2023
119 checks passed
@mansona mansona changed the title Update README.md Add section on importing a module for side affects only to the README.md Nov 24, 2023
This was referenced Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add polyfill use case to FAQ
3 participants