Fixes 595 in ember-learn/ember-api-docs - missing has-block API documentation #17767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue: ember-learn/ember-api-docs#595
I think there are a bunch of helpers that are more foundational to glimmer, like
{{yield}}
and{{with}}
where the documentation was just put in thepackages/@ember/-internals/glimmer/index.ts
, despite the real functionality living deeper below. This seems to fall into that bucket, which probably explains why the documentation is missing from the API docs. The clearest place where I could find where the{{has-block}}
helper is handled is:https://github.com/emberjs/ember.js/blob/master/packages/%40ember/-internals/glimmer/lib/component-managers/curly.ts#L239-L242
But really, I think there are a lot of places that actually contribute to this functionality. Probably documenting
{{has-block}}
in thepackages/@ember/-internals/glimmer/index.ts
file is the most straightforward place to put it.