Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around issue with pauseTest() timing out. #497

Merged
merged 1 commit into from
May 17, 2019
Merged

Work around issue with pauseTest() timing out. #497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions addon-test-support/ember-qunit/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ export function setupTest(hooks, _options) {
this.pauseTest = function QUnit_pauseTest() {
assert.timeout(-1); // prevent the test from timing out

// This is a temporary work around for
// https://github.com/emberjs/ember-qunit/issues/496 this clears the
// timeout that would fail the test when it hits the global testTimeout
// value.
clearTimeout(QUnit.config.timeout);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, as you intentionally want to pause tests indefinitely.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I also did confirm that calling resumeTest() does continue as expected. So basically clearing the timeout here just means that QUnit itself will wait for the promise to resolve forever....

return originalPauseTest.call(this);
};
});
Expand Down