Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pauseTest workaround #1178

Merged
merged 4 commits into from
Sep 14, 2024
Merged

Conversation

Krinkle
Copy link
Contributor

@Krinkle Krinkle commented Mar 3, 2024

Follows-up #497 which introduced this because QUnit 2.8 didn't support changing an existing assert.timeout() by calling it again in the same test (it would leave the old one unchanged, and start a second timeout).

This was fixed in QUnit 2.9.3, released in Oct 2019.

The ember-qunit package declares a peer dependency on qunit@2.13.0, which should remove the need for this workaround.

Ref #496.

Follows-up emberjs#497 which introduced
this because QUnit 2.8 didn't support changing an existing `assert.timeout()`
by calling it again in the same test (it would leave the old one unchanged,
and start a second timeout).

This was fixed in QUnit 2.9.3, released in Oct 2019.

The ember-qunit package declares a peer dependency on `qunit@2.13.0`,
which should remove the need for this workaround.

Ref emberjs#496.
@Krinkle
Copy link
Contributor Author

Krinkle commented Mar 3, 2024

The main reason I care is to confirm that it all works for what ember-qunit ultimately needs. (The isolated issue that we identified back then is long covered by upstream tests, but I'd like to confirm that there isn't something else at play.)

@NullVoxPopuli NullVoxPopuli merged commit 0fd92b5 into emberjs:main Sep 14, 2024
16 checks passed
@Krinkle Krinkle deleted the rm-pause-workaround branch September 14, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants