Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: don't mention unexisting ESA auth handler #9275

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

sly7-7
Copy link
Contributor

@sly7-7 sly7-7 commented Mar 22, 2024

Description

I think this could be confusing, and unless I miss something such handler does not exist, and I didn't see any open issue/PR in the ESA repo mentionning it

I think this could be confusing, and unless I miss something such handler does not exist, and I didn't see any open issue/PR in the ESA repo mentionning it
@sly7-7 sly7-7 changed the title don't mention unexisting ESA auth handler doc: don't mention unexisting ESA auth handler Mar 22, 2024
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I put this there as an example, as this is what ESA should refactor to do vs the approach it uses today. Thanks!

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ doc This PR adds/improves/or fixes documentation labels Mar 22, 2024
@runspired runspired merged commit 945ebfd into main Mar 22, 2024
25 of 29 checks passed
@runspired runspired deleted the sly7-7-doc-remove-esa-auth-handler branch March 22, 2024 20:18
sly7-7 added a commit that referenced this pull request Mar 28, 2024
runspired pushed a commit that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ doc This PR adds/improves/or fixes documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants