feat: docs, tests and fixes for create/update/deleteRecord builders #8849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltazore
commented
Sep 6, 2023
Baltazore
force-pushed
the
add-save-record-docs
branch
3 times, most recently
from
6b6fb7d
to
9d8be6c
Compare
leepfrog
reviewed
Sep 16, 2023
| export function createRecord(record: unknown, options: ConstrainedRequestOptions = {}): CreateRequestOptions { | ||
| const identifier = recordIdentifierFor(record); | ||
| assert(`Expected to be given a record instance`, identifier); | ||
| assert(`Cannot delete a record that does not have an associated type and id.`, isExisting(identifier)); | ||
| // TODO: seems to be wrong assert here, at least message is confusing | ||
| // assert(`Cannot delete a record that does not have an associated type and id.`, isExisting(identifier)); |
There was a problem hiding this comment.
+1 to wrong assertion, you should be able to create a record without an identifier.
There was a problem hiding this comment.
@leepfrog not exactly. You do need an identifier, the identifier does not need an id.
runspired
force-pushed
the
add-save-record-docs
branch
from
5bd87fe
to
c749f6f
Compare
runspired
added
🎯 canary
runspired
changed the title
runspired
reviewed
Sep 17, 2023
| // Handle testing feature flags | ||
| if (QUnit.urlParams.enableoptionalfeatures) { | ||
| window.EmberDataENV = { ENABLE_OPTIONAL_FEATURES: true }; | ||
| } | ||
|
|
||
| configureAsserts(); | ||
|
|
||
| setApplication(Application.create(config.APP)); |
There was a problem hiding this comment.
in follow up we should eliminate this and the new app files in favor of in-test-file registration
runspired
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for rest of the builder functions
This PR aims to cover create-record / update-record / delete-record documentation
Should be added to json-api / rest / active-record packages