Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more docs for builders #8825

Merged
merged 1 commit into from
Sep 4, 2023
Merged

feat: more docs for builders #8825

merged 1 commit into from
Sep 4, 2023

Conversation

runspired
Copy link
Contributor

Documents findRecord and query for ActiveModel/Rest/JSON:API as well as their respective /request sub packages

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ doc This PR adds/improves/or fixes documentation labels Sep 4, 2023
@runspired runspired merged commit e488c95 into main Sep 4, 2023
24 checks passed
@delete-merged-branch delete-merged-branch bot deleted the update-jar-docs branch September 4, 2023 09:04
* const data = await store.request(options);
* ```
*
* **Supplying Options to Modify the Request Behavior**
Copy link
Collaborator

@Baltazore Baltazore Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@runspired do you think we should add similar section of documentation to findRecord builder? I can do it if you think it makes sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ doc This PR adds/improves/or fixes documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants