Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] ensure @ember-data/serializer package encapsulation #6459

Merged
merged 6 commits into from
Sep 18, 2019

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Sep 17, 2019

This surfaces an issue that shows we have one more action item to fully encapsulate the @ember-data/serializer package as part of #6166

The issue is that @ember-data/store has an unexpected entanglement with the ember-data package still via the ember-data/-debug util. Since the ember-data package requires the @ember-data/serializer package this makes us not able to drop the package yet.

Action item to move this debug util into its own package.

@runspired runspired added 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality 🏷️ test This PR primarily adds tests for a feature labels Sep 17, 2019
@runspired
Copy link
Contributor Author

runspired commented Sep 17, 2019

Realized that only tests and @ember-data/store make use of this so I moved the util into the store package for now. Based on how it uses Model though (which is currently in the Store package`) long term it will either need to become stand-alone or move to the model package

@runspired runspired merged commit 152bcd3 into master Sep 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/encapsulation-test branch September 18, 2019 00:27
@runspired runspired removed the 🎯 canary PR is targeting canary (default) label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ cleanup This PR primarily removes deprecated functionality 🏷️ test This PR primarily adds tests for a feature 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants