Enable some strict checks

emberjs · Nov 15, 2023 · 93c38f4 · 93c38f4
1 parent ff5ac6c
commit 93c38f4
Show file tree

Hide file tree

Showing 11 changed files with 31 additions and 16 deletions.
diff --git a/config/eslint/typescript.cjs b/config/eslint/typescript.cjs
@@ -1,18 +1,33 @@
 function rules(config) {
   return Object.assign(
     {
-      '@typescript-eslint/ban-ts-comment': ['error', { 'ts-expect-error': false }],
+      '@typescript-eslint/adjacent-overload-signatures': 'error',
+      '@typescript-eslint/ban-ts-comment': 'off',
       'no-loop-func': 'off',
       '@typescript-eslint/no-loop-func': 'error',
       '@typescript-eslint/no-misused-promises': 'off',
       '@typescript-eslint/no-redundant-type-constituents': 'off',
       'no-shadow': 'off',
       '@typescript-eslint/no-shadow': 'error',
       'no-throw-literal': 'off',
+      '@typescript-eslint/no-inferrable-types': 'error',
+      '@typescript-eslint/no-meaningless-void-operator': 'error',
       '@typescript-eslint/no-throw-literal': 'error',
+      // Many failures for these; they seem intentional so I don't want to just auto-fix:
+      // '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
+      // '@typescript-eslint/no-unnecessary-condition': 'error',
+      '@typescript-eslint/no-unnecessary-type-arguments': 'error',
+      '@typescript-eslint/no-unnecessary-type-assertion': 'error',
+      '@typescript-eslint/no-unnecessary-type-constraint': 'error',
       '@typescript-eslint/no-unsafe-declaration-merging': 'off',
       '@typescript-eslint/no-unused-vars': ['error', { args: 'none' }],
+      'no-useless-constructor': 'off',
+      '@typescript-eslint/no-useless-constructor': 'error',
       '@typescript-eslint/prefer-includes': 'error',
+      // Auto-fix changes the types in some of these cases, which didn't seem safe:
+      // '@typescript-eslint/prefer-optional-chain': 'error',
+      '@typescript-eslint/prefer-reduce-type-parameter': 'error',
+      '@typescript-eslint/prefer-return-this-type': 'error',
       '@typescript-eslint/prefer-ts-expect-error': 'error',
       'prefer-const': 'error',
       'prefer-rest-params': 'off',

diff --git a/packages/graph/src/-private/-diff.ts b/packages/graph/src/-private/-diff.ts
@@ -31,7 +31,7 @@ function _deprecatedCompare<T>(
   const finalState: T[] = [];
 
   for (let i = 0, j = 0; i < iterationLength; i++) {
-    let adv: boolean = false;
+    let adv = false;
     let member: T | undefined;
 
     // accumulate anything added

diff --git a/packages/graph/src/-private/-edge-definition.ts b/packages/graph/src/-private/-edge-definition.ts
@@ -334,7 +334,7 @@ export function upgradeDefinition(
   graph: Graph,
   identifier: StableRecordIdentifier,
   propertyName: string,
-  isImplicit: boolean = false
+  isImplicit = false
 ): EdgeDefinition | null {
   const cache = graph._definitionCache;
   const storeWrapper = graph.store;

diff --git a/packages/graph/src/-private/graph.ts b/packages/graph/src/-private/graph.ts
@@ -421,7 +421,7 @@ export class Graph {
   update(op: LocalRelationshipOperation, isRemote?: false): void;
   update(
     op: MergeOperation | LocalRelationshipOperation | RemoteRelationshipOperation | UnknownOperation,
-    isRemote: boolean = false
+    isRemote = false
   ): void {
     assert(
       `Cannot update an implicit relationship`,

diff --git a/packages/graph/src/-private/operations/update-relationship.ts b/packages/graph/src/-private/operations/update-relationship.ts
@@ -21,8 +21,8 @@ export default function updateRelationshipOperation(graph: Graph, op: UpdateRela
 
   const payload = op.value;
 
-  let hasRelationshipDataProperty: boolean = false;
-  let hasUpdatedLink: boolean = false;
+  let hasRelationshipDataProperty = false;
+  let hasUpdatedLink = false;
 
   if (payload.meta) {
     relationship.meta = payload.meta;

diff --git a/packages/json-api/src/-private/cache.ts b/packages/json-api/src/-private/cache.ts
@@ -1561,7 +1561,7 @@ function _isEmpty(peeked: CachedResource | undefined): boolean {
   return (!isNew || isDeleted) && isEmpty;
 }
 
-function recordIsLoaded(cached: CachedResource | undefined, filterDeleted: boolean = false): boolean {
+function recordIsLoaded(cached: CachedResource | undefined, filterDeleted = false): boolean {
   if (!cached) {
     return false;
   }

diff --git a/packages/legacy-compat/src/legacy-network-handler/fetch-manager.ts b/packages/legacy-compat/src/legacy-network-handler/fetch-manager.ts
@@ -585,13 +585,13 @@ function _flushPendingFetchForType(
         _processCoalescedGroup(store, fetchMap, groups[i], adapter, modelName);
       }
     } else if (totalItems === 1) {
-      void _fetchRecord(store, adapter, pendingFetchItems[0]);
+      _fetchRecord(store, adapter, pendingFetchItems[0]);
     }
   }
 
   pendingFetchMap.forEach((pendingFetchItems) => {
     pendingFetchItems.forEach((pendingFetchItem) => {
-      void _fetchRecord(store, adapter, pendingFetchItem);
+      _fetchRecord(store, adapter, pendingFetchItem);
     });
   });
 }

diff --git a/packages/request/src/-private/context.ts b/packages/request/src/-private/context.ts
@@ -33,7 +33,7 @@ export class ContextOwner {
   response: ResponseInfo | null = null;
   declare request: ImmutableRequestInfo;
   declare enhancedRequest: ImmutableRequestInfo;
-  nextCalled: number = 0;
+  nextCalled = 0;
   declare god: GodContext;
   declare controller: AbortController;
   declare requestId: number;

diff --git a/packages/store/src/-private/caches/instance-cache.ts b/packages/store/src/-private/caches/instance-cache.ts
@@ -217,7 +217,7 @@ export class InstanceCache {
     return reference;
   }
 
-  recordIsLoaded(identifier: StableRecordIdentifier, filterDeleted: boolean = false) {
+  recordIsLoaded(identifier: StableRecordIdentifier, filterDeleted = false) {
     const cache = this.cache;
     if (!cache) {
       return false;

diff --git a/packages/store/src/-private/managers/notification-manager.ts b/packages/store/src/-private/managers/notification-manager.ts
@@ -216,7 +216,7 @@ export default class NotificationManager {
       }
       buffer.push([value, key]);
 
-      void this._scheduleNotify();
+      this._scheduleNotify();
     }
 
     return hasSubscribers;

diff --git a/packages/store/src/-private/record-arrays/identifier-array.ts b/packages/store/src/-private/record-arrays/identifier-array.ts
@@ -158,9 +158,9 @@ class IdentifierArray {
     @type Boolean
   */
   declare isUpdating: boolean;
-  isLoaded: boolean = true;
-  isDestroying: boolean = false;
-  isDestroyed: boolean = false;
+  isLoaded = true;
+  isDestroying = false;
+  isDestroyed = false;
   _updatingPromise: Promise<IdentifierArray> | null = null;
 
   [IS_COLLECTION] = true;
@@ -216,7 +216,7 @@ class IdentifierArray {
       links: options.links || null,
       meta: options.meta || null,
     };
-    let transaction: boolean = false;
+    let transaction = false;
 
     // when a mutation occurs
     // we track all mutations within the call