Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 2020-02-07-the-ember-times-issue-134.md #518

Merged
merged 4 commits into from
Feb 5, 2020
Merged

Update 2020-02-07-the-ember-times-issue-134.md #518

merged 4 commits into from
Feb 5, 2020

Conversation

MinThaMie
Copy link
Contributor

I'm a bit unsure about my intro text, so please let me know if you know something better :)

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Feb 4, 2020
@MinThaMie MinThaMie requested a review from a team February 4, 2020 20:31
@MinThaMie MinThaMie self-assigned this Feb 4, 2020
jayjayjpg
jayjayjpg approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! I left one more small suggestion, otherwise this is already good to go! Thank you for another ✨ writeup this week!

source/2020-02-07-the-ember-times-issue-134.md Outdated Show resolved Hide resolved
ijlee2
ijlee2 approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! In addition to Jessica's feedback, I left one more. Thanks for an early start!

MinThaMie and others added 2 commits February 5, 2020 08:44
@MinThaMie @jayjayjpg
Update source/2020-02-07-the-ember-times-issue-134.md
686bba3 
Co-Authored-By: Jessica Jordan <jessica.jordan.fe.dev@gmail.com>
@MinThaMie @ijlee2
Update source/2020-02-07-the-ember-times-issue-134.md
c919e9a 
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@MinThaMie @ijlee2
Update source/2020-02-07-the-ember-times-issue-134.md
6d7c9f7 
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@MinThaMie MinThaMie merged commit b8a5621 into blog/embertimes-134 Feb 5, 2020
@MinThaMie MinThaMie deleted the figma-blogpost branch February 5, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 approved these changes

@jayjayjpg jayjayjpg jayjayjpg approved these changes

Assignees

@MinThaMie MinThaMie

Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MinThaMie @jayjayjpg @ijlee2