Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with no-deprecated-router-transition-methods throwing errors outside of class usage #2046

Merged

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Dec 29, 2023

Ran in to this while trying out eslint-plugin-ember@v12-alpha on NullVoxPopuli/limber#1604

@NullVoxPopuli NullVoxPopuli changed the title Failing tets for no deprecatde router transition methods Failing tets for no-deprecated-router-transition-methods Dec 29, 2023
@NullVoxPopuli NullVoxPopuli changed the title Failing tets for no-deprecated-router-transition-methods Failing test for no-deprecated-router-transition-methods Dec 29, 2023
@NullVoxPopuli NullVoxPopuli changed the title Failing test for no-deprecated-router-transition-methods Fix issue with no-deprecated-router-transition-methods throwing errors outside of class usage Dec 29, 2023
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review December 29, 2023 20:04
@NullVoxPopuli NullVoxPopuli force-pushed the failing-test-for-no-deprecated-router-transition-methods branch from 803c8ef to cff149f Compare December 29, 2023 20:06
package.json Outdated Show resolved Hide resolved
lint:fix

eh
@NullVoxPopuli NullVoxPopuli force-pushed the failing-test-for-no-deprecated-router-transition-methods branch from cff149f to 2557701 Compare December 31, 2023 13:32
@NullVoxPopuli NullVoxPopuli mentioned this pull request Dec 31, 2023
@bmish bmish changed the title Fix issue with no-deprecated-router-transition-methods throwing errors outside of class usage Fix issue with no-deprecated-router-transition-methods throwing errors outside of class usage Dec 31, 2023
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmish bmish merged commit dff635a into master Dec 31, 2023
8 checks passed
@bmish bmish deleted the failing-test-for-no-deprecated-router-transition-methods branch December 31, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants