Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node 8 #532

Merged
merged 2 commits into from
Apr 11, 2020
Merged

Drop support for Node 8 #532

merged 2 commits into from
Apr 11, 2020

Conversation

buschtoens
Copy link
Contributor

@buschtoens buschtoens commented Mar 30, 2020

Node 8 reached its EOL and dependencies that stopped supporting it are now causing CI failures: #531 (comment)

This PR drops support for Node 8 and upgrades ember-source from ~3.14.3 to ~3.16.5 to combat emberjs/ember.js#18831.

@rwjblue
Copy link
Member

rwjblue commented Mar 30, 2020

The floating dep tests are failing for:

Global error: Uncaught TypeError: (0 , _emberBabel.createSuper) is not a function at http://localhost:7357/assets/vendor.js

tldr; we need to either downgrade to ember-source@3.12 or upgrade to 3.16 (to get emberjs/ember.js#18831)

@buschtoens
Copy link
Contributor Author

I'd prefer upgrading to 3.16. What would be your preference?

Copy link
Member

rwjblue commented Mar 30, 2020

I'd prefer upgrading to 3.16.

Yep, totally agree! I was just trying to help / point out what was going on...

@buschtoens
Copy link
Contributor Author

Can we merge this? :)
Or are you intentionally holding back, because it requires a breaking release? Would you like me to try to lock the offending dependencies, so that we can stay on Node 8 for now?

@rwjblue rwjblue merged commit 4f88462 into ember-cli:master Apr 11, 2020
@buschtoens
Copy link
Contributor Author

🎉

@rwjblue rwjblue changed the title 💥 [BREAKING] chore: drop support for Node 8 Drop support for Node 8 Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants