-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to V2 addon #303
base: master
Are you sure you want to change the base?
Convert to V2 addon #303
Conversation
e8cdbc8
to
1e97ef1
Compare
@@ -3,7 +3,7 @@ language: node_js | |||
node_js: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bwbuchanan maybe just delete this file and provide GitHub actions config instead?
@bwbuchanan would you like to incorporate recommendations from https://github.com/embroider-build/embroider/blob/main/PORTING-ADDONS-TO-V2.md? |
@SergeAstapov is this something we should take over? 😅 |
I suppose it doesn’t hurt, but does it really matter that this is v1 or v2 when the core thing that this addon does is iterating over require.entries to look for the initializers? Shouldn’t this functionality be implemented in embroider natively and make this addon unnecessary/no-op under embroider? |
@NullVoxPopuli I'd love gets this over the finish line! although this would fall somewhere in the queue of addons I do have maintainer access.
@chancancode as this point in time, the main problem with this addon is the fact that it depends on
TBH it always was a mystery to me why this addon even exists (maybe was a part of migration story from ember-app-kit to Ember CLI?). |
Yeah, if it's close and easy, like I said, I don't think it hurts to keep things up-to-date here. But personally, I think if this addon is still needed with Embroider/Polaris, then there is something deeply wrong. (Same deal as the fingerprinting stuff, etc.) So, personally, I think the priority should be making sure the functionality is implemented natively in Embroider. |
I think it's fine to make this change, and separately after we do https://github.com/emberjs/rfcs/blob/strict-es-module-support/text/0938-strict-es-module-support.md, use that to eliminate the dependence on requirejs.entries. |
This is an attempt at converting
ember-load-initializers
to the v2 addon format. Feedback welcomed.