Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shorthand ES6 syntax for addon -> app re-exports #3851

Merged
merged 1 commit into from
Apr 8, 2015

Conversation

jayphelps
Copy link
Member

Duplicate of #3739 but GitHub won't allow you to reopen PRs which have been force pushed.

@stefanpenner
Copy link
Contributor

LGTM

@stefanpenner
Copy link
Contributor

@jayphelps is this the only occurance of this pattern in the blueprints?

@jayphelps
Copy link
Member Author

@stefanpenner nope, I didn't see the recently merged #3690, updating this PR to reflect. Will ping when green.

@jayphelps jayphelps changed the title Use shorthand ES6 re-export for addon components Use shorthand ES6 syntax for addon -> app re-exports Apr 8, 2015
stefanpenner added a commit that referenced this pull request Apr 8, 2015
Use shorthand ES6 syntax for addon -> app re-exports
@stefanpenner stefanpenner merged commit 2ef2f55 into ember-cli:master Apr 8, 2015
@jayphelps
Copy link
Member Author

@stefanpenner ...wasn't done hehe was updating with #3690 changes. I'll do a new PR for the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants