[0.5.0] Plugin base class restructure #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemelia
force-pushed
the
plugin-base-class-restructure
branch
from
b07c19a
to
9556253
Compare
lukemelia
force-pushed
the
plugin-base-class-restructure
branch
from
9556253
to
d876846
Compare
In real-world experience developing our first 8 plugins, we have had no need for appConfig, so we’re dropping support for it. We have a plan to reintroduce if later plugin development makes it necessary or useful.
* Removes `deployment` node in favor of moving ui, config, etc properties to top level of "context". * Invokes `beforeHook` on a plugin (if defined) before each hook is called.
lukemelia
force-pushed
the
plugin-base-class-restructure
branch
from
d876846
to
6c8e6d1
Compare
lukemelia
changed the title
This was referenced Jul 13, 2015
Merged
achambers
pushed a commit
that referenced
this pull request
Jul 13, 2015
[0.5.0] Plugin base class restructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure to support plugin base class.
deploymentnode in favor of moving ui, config, etc properties to top level of "context".beforeHookon a plugin (if defined) before each hook is called.Merge of this should be coordinated with similar named branch among all 0.5.0 plugins.
Plugin PR's to merge: