Add confi option for signatureVersion #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pedrokost thanks for this! I think you need to tweak the tests If you can do that and amend your commit we should be good to go! |
|
@ghedamat The Travis CI error was caused a network connection error and not by a failed test. I am confident the tests would pass if the tests are rerun. |
|
@pedrokost sounds good! I'll restart them as soon as I can and let you know! |
|
thanks @pedrokost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed & Why
Made it possible to set the signature version for AWS S3.
More information about this option is available in this AWS S3 documentation page.
Related issues
#82
PR Checklist