Update ember cli 2.10 #80
Conversation
This includes running `ember init` and updating blueprints.
|
@jrjohnson This looks good. As discussed in Slack, I'd ultimately like to remove standard files that serve no purpose in this addon. e.g. stuff related to qunit/in-browser testing. That should be a separate PR anyway, though. |
| - npm install | ||
| - bower install | ||
|
|
||
| script: | ||
| - npm test |
There was a problem hiding this comment.
@jrjohnson this change is not appropriate because it makes travis try to run ember tests instead of the node tests specified in package.json.
There was a problem hiding this comment.
Damn. I fixed that. Must have gotten lost when I was messing with what to include / not include in this PR. Good catch. Sorry. I pushed the fix, should I squash commits? Or do you prefer them separate?
|
@lukemelia yes. I was thinking I would sweep through several plugins and update ember-cli and then go back through and start pulling out things like ember-try, qunit, etc... that are not being used. Also not included here is that JSHint isn't running in CI so some errors are not being caught - but that seems like a different PR as well. |
What Changed & Why
In the interests of staying current I updated dependancies and blueprints for ember-cli 2.10.0. The only material changes made were to tests/unit/index-nodetest.js and tests/unit/lib/s3-nodetest.js where I copied the advised template from http://ember-cli-deploy.com/docs/v0.6.x/writing-a-plugin/