filesUploaded should return all files when using manifest #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @wongpeiyi. Would it be possible to get test coverage in place for this? |
`filesUploaded` is currently only `[manifest.txt]` if using a manifest
wongpeiyi
force-pushed
the
fix/filesUploaded_only_manifest
branch
from
f56a58c
to
548606d
Compare
|
Thanks for the response, added tests. @lukemelia let me know if it needs more work? |
|
@lukemelia can I trouble you to look at this again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #55
context.filesUploadedwill only return['manifest.txt']if using a manifestThis returns the originally uploaded files in addition to the manifest