This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
WriteAllError type #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
reviewed
May 10, 2023
Dirbaio
reviewed
May 10, 2023
Dirbaio
reviewed
May 10, 2023
|
Could you do the equivalent changes in |
Instead of panicking when writing zero byte with `write_all`, it now returns a `WriteZeroError`.
Done :) |
MabezDev
commented
May 12, 2023
|
@Dirbaio, sorry for the ping! Any more thoughts on this PR? |
|
LGTM. This is a breaking change though. It'll require releasing 0.5 though, which is a breaking change. I wonder if there's other breaking changes we might wish to do before that? |
|
Nothing off the top of my head. The only other open issue is #17 which won't be a breaking change anyway as the enum is marked as non-exhaustive. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
Instead of panicking when writing zero bytes with
write_all, it now returns aWriteZeroError.I couldn't see an easy way to avoid duplicating the
WriteZerovariant inWriteFmtError, but it would be nice to not have this duplication.