dumper: Support frozen strings #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please let me know if you want me to add the frozen string comment to the header of the file. |
ekohl
reviewed
Jan 19, 2022
|
Hi @bastelfreak thanks for your contribution! |
In Ruby 2.7 and newer, frozen strings became a thing. I maintain a Puppet module where the dumper.rb got vendored in and frozen strings are now enbled in the module. With this patch the dumper.rb supports frozen strings.
|
@emancu thanks for the feedback, should be fine now. |
emancu
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby 2.7 and newer, frozen strings became a thing. I maintain a
Puppet module where the dumper.rb got vendored in and frozen strings are
now enbled in the module. With this patch the dumper.rb supports frozen
strings.