-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perpetual]: New Liquidation System #766
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
==========================================
+ Coverage 43.35% 43.62% +0.27%
==========================================
Files 640 641 +1
Lines 21127 21493 +366
==========================================
+ Hits 9160 9377 +217
- Misses 10892 11002 +110
- Partials 1075 1114 +39 |
// TODO: Handle stop loss | ||
ctx.EventManager().EmitEvent(sdk.NewEvent(types.EventClosePositions, | ||
sdk.NewAttribute("liquidations", strings.Join(liqLog, "\n")), | ||
//sdk.NewAttribute("stop_loss", strings.Join(closeLog, "\n")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amityadav0 can we get rid of that?
return sdk.ZeroInt(), err | ||
} | ||
err = k.bankKeeper.SendCoins(ctx, ammPoolAddr, fundAddr, takeCoins) | ||
//err := k.bankKeeper.SendCoinsFromModuleToAccount(ctx, ammPool.Address, fundAddr, takeCoins) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amityadav0 can we get rid of this comment line?
Description
What has Changed?
What specific problem were you aiming to address, and how did you successfully resolve it? If tests were not uploaded for this pull request or if coverage decreased, please provide an explanation for the change.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeDeployment Notes
Are there any specific considerations to take into account when deploying these changes? This may include new dependencies, scripts that need to be executed, or any aspects that can only be evaluated in a deployed environment.
Screenshots and Videos
Please provide any relevant before and after screenshots by uploading them here. Additionally, demo videos can be highly beneficial in demonstrating the process.