feat: add dynamic leverage #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
==========================================
- Coverage 43.53% 43.31% -0.23%
==========================================
Files 652 650 -2
Lines 21622 21570 -52
==========================================
- Hits 9414 9342 -72
- Misses 11090 11114 +24
+ Partials 1118 1114 -4 |
amityadav0
requested changes
Aug 29, 2024
tests are updated already with different leverage for the same position , and also add collateral where lev = 1 |
|
@cryptokage1996 |
@cosmic-vagabond this will be fixed after #758 is merged refrence |
|
@cryptokage1996 ran another test and the the stablestake module data are part of the localnet snapshot now: cc @amityadav0 |
|
@cryptokage1996 please have a look at the latest test result using the stablestake module data: this time over, we can see the liabilities values are on, but for all the positions I tested on the |
if you look closely into the response for any position for eg lets pick a position with address elys1llll3p0zvykqhxtqhlfw4qu6p9llrxrgskhx0z (last position) if you see there position health
position health is calculated = exitAmountAfterFee / Liabilities So, position health is less than 1. which means Liabilities > exitAmountAfterFee. updated leverage = exitAmountAfterFee / (exitAmountAfterFee - liabilities) (exitAmountAfterFee - liabilities) is negative. if (exitAmountAfterFee - liabilities) is not positive we will set updated_leverage as zero. |
|
@cryptokage1996 you are right those are zombi positions, I wonder though why the bot did not liquidate them cc @amityadav0 @fenriz07 @cryptokage1996 I created a new position and queried it and now I can see a positive value for updated_leverage: this is the command I used for created the position: So I wonder why even though the position was created with a 5x leverage we ends up with a 6.35x leverage, there was no price movement at all and the position size is about 500usdc it should cause too much slippage neither. |
|
@cryptokage1996 ’s test results: consolidation: |
cosmic-vagabond
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable users to adjust the leverage of an existing position when adding new collateral, allowing for flexibility in leverage management and improving user experience.
What has Changed?