Avkr003/commitment keys #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avkr003 there is a migration error with the commitment module see https://github.com/elys-network/elys/actions/runs/10352124043/job/28657954291?pr=711#step:21:50 |
|
I might not be aware of this, v3 to v4 migration have been done? Looks like not because it's trying to find that. |
|
@cosmic-vagabond fixed. |
…003/commitmentKeys
cosmic-vagabond
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes keys for commitments.
For secp256k1 type addresses, the earlier key took 43 bytes for hrp = "elys" as it converted the bech32 address string to a byte array. Now it directly utilises sdk.AccAddress type is a byte array of length 20 bytes for secp2556k1 addresses. + 1 byte for length
For secp256r1, it will take 32 bytes + 1 byte for length. (the bec32 address string for this type will be higher than 43 characters)
Tested for migration with chain upgrade.