Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simple earn Apr #693

Merged
merged 5 commits into from
Aug 12, 2024
Merged

fix: simple earn Apr #693

merged 5 commits into from
Aug 12, 2024

Conversation

cryptokage1996
Copy link
Contributor

@cryptokage1996 cryptokage1996 commented Aug 5, 2024

Description

Closes:
https://trello.com/c/S0ETSMB0/344-pool-apr-is-wrong
https://trello.com/c/PahNxmt8/483-simple-earn-apr-is-returning-0

What has Changed?

Simple Apr returning zero , as it is truncating dec values to int so precession is loss


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Deployment Notes

Are there any specific considerations to take into account when deploying these changes? This may include new dependencies, scripts that need to be executed, or any aspects that can only be evaluated in a deployed environment.

Screenshots and Videos

Please provide any relevant before and after screenshots by uploading them here. Additionally, demo videos can be highly beneficial in demonstrating the process.

@cryptokage1996 cryptokage1996 marked this pull request as ready for review August 9, 2024 12:12
@cosmic-vagabond cosmic-vagabond merged commit 05ca0ed into main Aug 12, 2024
2 checks passed
@cosmic-vagabond cosmic-vagabond deleted the feat/pool-apr-query branch August 12, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants