Fix APR calculation #574
Merged
Fix APR calculation #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add calculate discount test and bug fix * get asset by denom
* ci: use post-upgrade-snapshot-generator * ci: update delete snapshot CI to use post upgrade snapshot gen binary
Wgil
reviewed
Jun 18, 2024
| @@ -13,7 +13,7 @@ import ( | |||
|
|
|||
| func CmdRewards() *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "get-position [address] [position-ids]", | |||
| Use: "rewards [address] [position-ids]", | |||
There was a problem hiding this comment.
Please update below line too:
Short: "Query position"
fenriz07
approved these changes
Jun 18, 2024
fenriz07
added a commit
that referenced
this pull request
Jun 18, 2024
* [Bug]: Fix calculate discount and add more tests (#570) * add calculate discount test and bug fix * get asset by denom * ci: use post-upgrade-snapshot-generator (#571) * ci: use post-upgrade-snapshot-generator * ci: update delete snapshot CI to use post upgrade snapshot gen binary * fix 24hr apr tracking * fix rewards query * query rewards fix * Update version * fix rewards query description --------- Co-authored-by: jelysn <129082781+jelysn@users.noreply.github.com> Co-authored-by: Amit Yadav <amy29981@gmail.com> Co-authored-by: Cosmic Vagabond <121588426+cosmic-vagabond@users.noreply.github.com> Co-authored-by: Warao Gil <wari@elys.network>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.