[feature] support k8s.io/api/admission/v1

[drnic]

There are two versions APIs for webhooks, and two corresponding APIs versions for the webhook request + response which is handled by this library

https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#webhook-request-and-response

• admissionregistration.k8s.io/v1beta1 - handled by this library, but deprecated in kube v1.16
• admissionregistration.k8s.io/v1

Do you have some ideas how this library might migrate to support the new API? Support both in parallel; drop v1beta1 and only support v1; or not support v1 for some X months/Y years and move only when v1beta1 starts being removed?

[elithrar]

I'll likely move to v1 - given that this library hasn't seen a v1.0.0 itself yet - as a "breaking" change.

…

On Sat, Jan 4, 2020 at 11:32 AM Dr Nic Williams ***@***.***> wrote: There are two APIs for webhooks, and two corresponding APIs for the webhook request + response which is handled by this library https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#webhook-request-and-response - admissionregistration.k8s.io/v1beta1 - handled by this library, but deprecated in kube v1.16 - admissionregistration.k8s.io/v1 Do you have some ideas how this library might migrate to support the new API? Support both in parallel; drop v1beta1 and only support v1; or not support v1 for some X months/Y years and move only when v1beta1 starts being removed? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#20?email_source=notifications&email_token=AAAEQ4GUFUVJBHKQ2QJYX4TQ4DP3TA5CNFSM4KCXRYC2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IEA7D7A>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAEQ4GNILB5KV6NZHHRM7DQ4DP3TANCNFSM4KCXRYCQ> .

[drnic]

I understand the business of "which kube APIs to support" isn't trivial -- GKE default kubernetes version is 1.14 for example.