[grid] Fixing Node drain when session expires

Helps with SeleniumHQ#9845
elgatov · Jun 27, 2022 · f3e1500 · f3e1500
1 parent 927f2a7
commit f3e1500
Showing 1 changed file with 21 additions and 22 deletions.
diff --git a/java/src/org/openqa/selenium/grid/node/local/LocalNode.java b/java/src/org/openqa/selenium/grid/node/local/LocalNode.java
@@ -161,32 +161,41 @@ private LocalNode(
                            String.format("%s is %s", uri, status.getAvailability()));
                        } : healthCheck;
 
+    this.tempFileSystems = CacheBuilder.newBuilder()
+      .expireAfterAccess(sessionTimeout)
+      .ticker(ticker)
+      .removalListener((RemovalListener<SessionId, TemporaryFilesystem>) notification -> {
+        TemporaryFilesystem tempFS = notification.getValue();
+        tempFS.deleteTemporaryFiles();
+        tempFS.deleteBaseDir();
+      })
+      .build();
+
     this.currentSessions = CacheBuilder.newBuilder()
       .expireAfterAccess(sessionTimeout)
       .ticker(ticker)
       .removalListener((RemovalListener<SessionId, SessionSlot>) notification -> {
         if (notification.getKey() != null && notification.getValue() != null) {
           // Attempt to stop the session
           SessionSlot slot = notification.getValue();
-          if (!slot.isAvailable()) {
-            slot.stop();
+          SessionId sessionId = notification.getKey();
+          slot.stop();
+          // Invalidate temp file system
+          this.tempFileSystems.invalidate(sessionId);
+          // Decrement pending sessions if Node is draining
+          if (this.isDraining()) {
+            int done = pendingSessions.decrementAndGet();
+            if (done <= 0) {
+              LOG.info("Node draining complete!");
+              bus.fire(new NodeDrainComplete(this.getId()));
+            }
           }
         } else {
           LOG.log(Debug.getDebugLogLevel(), "Received stop session notification with null values");
         }
       })
       .build();
 
-    this.tempFileSystems = CacheBuilder.newBuilder()
-      .expireAfterAccess(sessionTimeout)
-      .ticker(ticker)
-      .removalListener((RemovalListener<SessionId, TemporaryFilesystem>) notification -> {
-        TemporaryFilesystem tempFS = notification.getValue();
-        tempFS.deleteTemporaryFiles();
-        tempFS.deleteBaseDir();
-      })
-      .build();
-
     ScheduledExecutorService sessionCleanupNodeService =
       Executors.newSingleThreadScheduledExecutor(
         r -> {
@@ -486,16 +495,6 @@ public void stop(SessionId id) throws NoSuchSessionException {
     }
 
     currentSessions.invalidate(id);
-    tempFileSystems.invalidate(id);
-
-    // Decrement pending sessions if Node is draining
-    if (this.isDraining()) {
-      int done = pendingSessions.decrementAndGet();
-      if (done <= 0) {
-        LOG.info("Node draining complete!");
-        bus.fire(new NodeDrainComplete(this.getId()));
-      }
-    }
   }
 
   private void stopAllSessions() {