AppInfoView: warn about direct geoclue access #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2023
zeebok
previously approved these changes
May 28, 2023
|
@zeebok yeah exactly it would throw an error and bail out early without checking any of the other keys |
|
Okay, makes sense. Guess now there's a conflict with master though lol |
|
@zeebok yeah it’s just adding files to the gresource. Should be fixed :) |
zeebok
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a location portal, shame apps for accessing geoclue directly.
While we're here, prevent a bunch of keyfile errors that caused permissions not to be displayed correctly