Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage placeholder #2030

Merged
merged 3 commits into from
May 11, 2023
Merged

Homepage placeholder #2030

merged 3 commits into from
May 11, 2023

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented May 4, 2023

Bring back the placeholder on the homepage from before #1662

This prevents the page contents from changing so much on startup. Also make sure we don't start the timer until we finish loading banners. Fixes some terminal warnings about switching to a non-existent widget

@danirabbit danirabbit requested a review from a team May 4, 2023 23:38
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly. One small nitpick in the code

src/Views/Homepage.vala Outdated Show resolved Hide resolved
Co-authored-by: Leo <lenemter@gmail.com>
@danirabbit danirabbit enabled auto-merge (squash) May 11, 2023 14:31
@danirabbit danirabbit merged commit 521804e into master May 11, 2023
@danirabbit danirabbit deleted the homepage-placeholder branch May 11, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants