-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppInfoView: rework vertical spacing #2024
Conversation
Perhaps it could be made even tighter (when needed) by showing only the icon, the title of the app, the flatpak remote and price? All inline. Although maybe this would overcomplicate the code :) |
Yeah it's because of the height of the little info icon next to the size label, when that pops it in changes the height of that row. Probably what we can do is make sure to always show a label there with some placeholder text, but I think that might be better handled in a separate branch since this is also an issue in master
I think this is actually pretty non-trivial in Gtk 😅 I'll give it a try haha @aitor-gomila
I think it would make it significantly more complicated to make that work at smaller window widths. I'd like to make the package origin selector a lot more compact in a separate branch, but now the limiting factor here is actually the 128px icon that we use so there's not a significant height difference between having it and not |
@lenemter so I tried with Gtk.AspectFrame but it seems like I can't get the button to fill height anymore so it's square but too small. So I did a little hack in CSS and it's not perfectly square, but it's more square 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now uninstall button looks a lot nicer, thanks! Great job 👍
Meant to address some concerns about app descriptions being really far down the page. Also helps out at small window widths and just makes some of the padding and margins more consistent and pleasant, alignment of buttons etc as well. Puts releases in a carousel so that they don't push links down further
BEFORE
AFTER