Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppInfoView: rework vertical spacing #2024

Merged
merged 8 commits into from
May 11, 2023
Merged

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented May 3, 2023

Meant to address some concerns about app descriptions being really far down the page. Also helps out at small window widths and just makes some of the padding and margins more consistent and pleasant, alignment of buttons etc as well. Puts releases in a carousel so that they don't push links down further

BEFORE

Screenshot from 2023-05-02 18 19 10
Screenshot from 2023-05-02 18 18 47

AFTER

Screenshot from 2023-05-02 18 19 48

Screenshot from 2023-05-02 18 13 10

Screenshot from 2023-05-03 14 00 41
Screenshot from 2023-05-03 13 58 43

@danirabbit danirabbit requested a review from a team May 3, 2023 01:24
@lenemter
Copy link
Member

lenemter commented May 4, 2023

I like this!
The issues I noticed:

  • The spacing between app name and its description is changing when app info is loaded
    image
    image
  • Why not make uninstall button a square, IMO it would look better (if this is simple enough to do in gtk ).

@ghost
Copy link

ghost commented May 4, 2023

Perhaps it could be made even tighter (when needed) by showing only the icon, the title of the app, the flatpak remote and price? All inline.

Although maybe this would overcomplicate the code :)

@danirabbit
Copy link
Member Author

danirabbit commented May 4, 2023

@lenemter

The spacing between app name and its description is changing when app info is loaded

Yeah it's because of the height of the little info icon next to the size label, when that pops it in changes the height of that row. Probably what we can do is make sure to always show a label there with some placeholder text, but I think that might be better handled in a separate branch since this is also an issue in master

Why not make uninstall button a square

I think this is actually pretty non-trivial in Gtk 😅 I'll give it a try haha

@aitor-gomila

Perhaps it could be made even tighter (when needed) by showing only the icon, the title of the app, the flatpak remote and price? All inline.

I think it would make it significantly more complicated to make that work at smaller window widths. I'd like to make the package origin selector a lot more compact in a separate branch, but now the limiting factor here is actually the 128px icon that we use so there's not a significant height difference between having it and not

@danirabbit
Copy link
Member Author

@lenemter so I tried with Gtk.AspectFrame but it seems like I can't get the button to fill height anymore so it's square but too small. So I did a little hack in CSS and it's not perfectly square, but it's more square 😅

Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now uninstall button looks a lot nicer, thanks! Great job 👍

@danirabbit danirabbit merged commit 828e916 into master May 11, 2023
@danirabbit danirabbit deleted the appinfopage-vspacing branch May 11, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants