Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppListUpdateView: Rewrite with ListStore #1979

Merged
merged 10 commits into from
Jan 29, 2023

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 28, 2023

Rewrites things to use a ListStore of packages which makes things like removing, sorting, adding, etc more straightforward. Separating handling data from handling UI

  • Remove unused public methods
  • Remove single-use methods
  • Use functions from ListStore for clear and remove
  • We don't need to check os_updates or runtime_updates before adding because we already do that
  • Only call show_all () when the model changes.
  • We already refresh the model on client.installed_apps_changed, so we don't need to also explicitly call remove from the AppinfoView

@danirabbit danirabbit requested a review from a team January 28, 2023 17:56
@danirabbit danirabbit changed the title AppListUpdateView: remove unused public add_package AppListUpdateView: Rewrite with ListStore Jan 28, 2023
@danirabbit danirabbit enabled auto-merge (squash) January 29, 2023 20:41
@danirabbit danirabbit merged commit 67e5f63 into master Jan 29, 2023
@danirabbit danirabbit deleted the applistupdateview-fewerinvalidate branch January 29, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants