-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ELE-2241 - add tags to report test results #1340
ELE-2241 - add tags to report test results #1340
Conversation
👋 @IDoneShaveIt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -25,9 +25,11 @@ class TestResultDBRowSchema(ExtendedBaseModel): | |||
test_results_description: Optional[str] | |||
owners: Optional[List[str]] | |||
model_owner: Optional[List[str]] | |||
tags: Optional[List[str]] | |||
tags: List[str] = Field(default_factory=list) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well there is other place that uses it and this is the combination of model tags and test_tags.
I guess I will make it a property that return the union of the 2 🙂
@@ -62,6 +62,7 @@ class TestMetadataSchema(BaseModel): | |||
description: Optional[str] = None | |||
result: dict | |||
configuration: dict | |||
test_tags: List[str] = Field(default_factory=list) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should add this to SourceFreshnessMetadataSchema
as well (just empty always). just because we are planning to use this field for all items in the table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
No description provided.